Make long polling interval a command line parameter option#61
Open
jhorman wants to merge 3 commits intospulec:masterfrom
Open
Make long polling interval a command line parameter option#61jhorman wants to merge 3 commits intospulec:masterfrom
jhorman wants to merge 3 commits intospulec:masterfrom
Conversation
Also lowers the default to 10, 20 is just a long time to wait, and leads to shutdowns taking a long time.
Collaborator
|
Hey jhornman, Thanks for submitting this as well. Looks like a solid addition. The tests are failing due to an issue with boto. We can figure out how to migrate the tests to boto3 and avoid the problem, or fix the config so it isn't looking at GCE. I can work on adding this in shortly. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also lowers the default polling interval to 10, 20 is just a long time to wait, and leads to shutdowns taking a long time.
Fixes #60