Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from using the attrs library to Python's built-in dataclasses, removing an external dependency and improving the title extraction logic for documents.
- Replaces
attrsdecorators with standarddataclassesthroughout the codebase - Updates default field initialization to use
field(default_factory=...)to avoid mutable default arguments - Improves title extraction to require at least one word character in fallback lines
- Removes
attrsdependency from project configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/sqlite_rag/models/document.py | Migrates from attrs to dataclasses, fixes mutable defaults, and improves title extraction logic |
| src/sqlite_rag/models/chunk.py | Updates import from attrs to dataclasses |
| src/sqlite_rag/sqliterag.py | Adds .copy() calls to metadata parameters to prevent mutation |
| pyproject.toml | Removes attrs dependency |
| tests/test_sqlite_rag.py | Adds test for document title generation functionality |
| tests/models/test_document.py | Adds test case for title extraction with word requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aed5038 to
1b5b986
Compare
chore(dependencies): remove attrs
1b5b986 to
2989f31
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
aa89b09 to
90dff87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.