Merged
Conversation
added 4 commits
September 10, 2025 15:49
…l case insensitive
…method log::Level::from_str()
lovasoa
requested changes
Sep 11, 2025
Collaborator
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
Good, I'm in line with the general approach ! I made a few comments below.
Collaborator
|
Good; I'll refactor to avoid the duplication and cloning between RequestInfo and RequestContext, but this is out of scope for this pr. I think all that is missing before we can merge is
|
Collaborator
|
Another thing that would be nice is for the log component to work while in header context. Currently logging something switches to html rendering, which means you can't log anything before the shell. |
Contributor
Author
|
where can i define or search for a icon the component should get? |
Collaborator
lovasoa
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the logger component based on the Idea #985, with the small change of renaming "output" to "message".
It is not documented yet, since i am still trying to wrap my head around the documentation, but i wanted to know what you think, before committing any further.