Merged
Conversation
Co-authored-by: contact <contact@ophir.dev>
|
Cursor Agent can help with this pull request. Just |
Collaborator
Author
|
@cursoragent make a separate set_custom_connect_options_odbc and cargo fmt, clippy and so on before push |
|
I refactored the database connection setup by extracting ODBC-specific configuration into its own dedicated function, improving code organization and maintainability. This change ensures that ODBC connection options, such as removing the maximum column size limit, are handled in a more modular way.
2 tasks completed
Learn more about Cursor Agents |
Co-authored-by: contact <contact@ophir.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
OdbcConnectOptions::max_column_size(None)to allow fetching large text fields and handle ODBC passwords by warning instead of panicking.ODBC connections expect credentials to be part of the DSN or connection string. Previously, attempting to set a password separately for an ODBC connection could lead to unexpected behavior or panics; this change now logs a warning and ignores the separate password.