Closed
Conversation
|
Cursor Agent can help with this pull request. Just |
Collaborator
Author
|
@cursoragent valgrind must run in the existing tests (the ones defined with a strategy matrix), not in a new different test. And do not touch my cargo lock |
|
Perfect! I've successfully updated the PR to address your feedback: Changes Made✅ Integrated valgrind into the existing test matrix - Valgrind now runs within the existing ✅ Did not touch Cargo.lock - The commit only modifies How it works:
The tests have been verified locally and show 0 memory errors from valgrind. Learn more about Cursor Agents |
- Add valgrind installation step to test job - Run all matrix tests under valgrind using CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER - Remove separate valgrind job in favor of integration with existing tests
31ef654 to
0fa6f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a CI job to run unit tests under Valgrind to detect memory safety issues.