Added options to save and load model weights/parameters#3
Open
comadan wants to merge 1 commit intosrendle:masterfrom
comadan:master
Open
Added options to save and load model weights/parameters#3comadan wants to merge 1 commit intosrendle:masterfrom comadan:master
comadan wants to merge 1 commit intosrendle:masterfrom
comadan:master
Conversation
Owner
|
Thanks for your contribution. I quickly scanned your code and it might work. However, using this code is likely to cause problems for other users. Your code only works correctly if the id-range and mapping in the training and test files is not changed (i.e. no new features, feature-id mapping should remain unchanged). Moreover, when running MCMC, it only recovers the last state of the chain. This might be unexpected for common users and might generate lots of questions. I won't merge the code into the main branch because it might cause problems for inexperienced users. Users who are aware of the issues above can try your load/save code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added options to the command line tool for saving the model weights/parameters w0, w, v. This way a trained model can be reused.
I've never done any c++ programming or used github really. I also only have a high level understanding of libFM. So there's a decent chance these changes are very wrong...