bugfix/add: замена камеры на штативную#8557
Open
NuSanya wants to merge 6 commits intoss220-space:master220from
Open
bugfix/add: замена камеры на штативную#8557NuSanya wants to merge 6 commits intoss220-space:master220from
NuSanya wants to merge 6 commits intoss220-space:master220from
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully replaces the legacy video camera system with a new, more functional broadcast camera, improving organization by moving code to a separate file. However, a significant security regression has been introduced: the sanitization of chat messages is explicitly disabled in the hear_talk procedure, making it vulnerable to HTML injection and XSS attacks. Furthermore, there are several areas for improvement concerning performance and stability, including a critical risk of hard deletion in Destroy(), inefficient global searches in update_feeds(), and overly complex logic in init_camera().
Contributor
Author
|
merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что этот ПР делает
Заменяет старую video camera на новую broadcast camera, при этом исправляя существующие с старой камерой баги.
Вернул закоменченные перчатки что бьют током в набор дарклорда, ибо попалось под руку и лень отдельный пр под это делать. Как понимаю, это для будущего боевого искусства было закомменчено, но сомневаюсь, что оно будет.
Демонстрация изменений
Демонстрации изменений
2026-03-03.104338.1.mp4