experiment: АВД реворк#8561
Open
Etrnlmelancholy wants to merge 3 commits intoss220-space:master220from
Open
Conversation
github-actions
bot
added
🗺️ Изменение карты
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Аналитический отчёт от Большого Брата. Обработка запроса завершена.
Приветствую! Я проанализировал предложенные Вами изменения. С технической точки зрения, работа выглядит требующей доработок.
Сводка анализа:
- 🔴 Критических замечаний: 1
- 🟡 Рекомендаций: 4
- 💡 Предложений: 0
🔴 Критические замечания (требуют обязательного исправления):
code/game/jobs/job/supervisor.dm:260-261: Обнаружены ссылки на несуществующие типы объектов, что приведет к ошибке при компиляции.
🟡 Рекомендации по улучшению:
code/game/objects/items/devices/radio/headset.dm:510-517: Обнаружены некорректные склонения в локализации предмета.code/game/objects/items/devices/radio/headset.dm:520: Локализация для альтернативной версии гарнитуры (get_ru_names()) не была обновлена.code/modules/clothing/suits/jobs.dm:442: Обнаружена опечатка в комментарии.code/modules/clothing/under/jobs/civilian.dm:181: Обнаружена грамматическая ошибка в описании предмета.
Пожалуйста, ознакомьтесь с комментариями к отдельным строкам кода для получения более подробной информации.
Спасибо за ваш вклад в проект!
|
|
||
| /obj/item/radio/headset/headset_iaa/alt | ||
| name = "internal affairs bowman headset" | ||
| name = "lawyer bowman headset" |
Contributor
There was a problem hiding this comment.
🟡 Рекомендация по улучшению локализации
Вы обновили название для /obj/item/radio/headset/headset_iaa/alt, но соответствующая функция локализации get_ru_names() для этого типа (строки 529-537 в полной версии файла) осталась без изменений и по-прежнему содержит текст «Агента Внутренних Дел». Рекомендую обновить и её для консистентности.
Contributor
|
🫃🫃🫃 |
Contributor
|
Joey Petunia is a damn good lawyer |
Contributor
Author
Man I miss Melbert so much |
pilygun
reviewed
Mar 4, 2026
| /obj/item/paper/blueshield | ||
| name = "paper- 'Blueshield Mission Briefing'" | ||
| info = "<b>Blueshield Mission Briefing</b><br>You are charged with the defence of any persons of importance within the station. This includes, but is not limited to, The Captain, The Heads of Staff and Central Command staff. You answer directly to the Nanotrasen Representative who will assist you in achieving your mission.<br>When required to achieve your primary responsibility, you should liaise with security and share resources; however, the day to day security operations of the station are outside of your jurisdiction.<br>Monitor the health and safety of your principals, identify any potential risks and threats, then alert the proper departments to resolve the situation. You are authorized to act as bodyguard to any of the station heads that you determine are most in need of protection; however, additional access to their departments shall be granted solely at their discretion.<br>Observe the station alert system and carry your armaments only as required by the situation, or when authorized by the Head of Security or Captain in exceptional cases.<br>Remember, as an agent of Nanotrasen it is your responsibility to conduct yourself appropriately and you will be held to the highest standard. You will be held accountable for your actions. Security is authorized to search, interrogate or detain you as required by their own procedures. Internal affairs will also monitor and observe your conduct, and their mandate applies equally to security and Blueshield operations." | ||
| info = "<b>Blueshield Mission Briefing</b><br>You are charged with the defence of any persons of importance within the station. This includes, but is not limited to, The Captain, The Heads of Staff and Central Command staff. You answer directly to the Nanotrasen Representative who will assist you in achieving your mission.<br>When required to achieve your primary responsibility, you should liaise with security and share resources; however, the day to day security operations of the station are outside of your jurisdiction.<br>Monitor the health and safety of your principals, identify any potential risks and threats, then alert the proper departments to resolve the situation. You are authorized to act as bodyguard to any of the station heads that you determine are most in need of protection; however, additional access to their departments shall be granted solely at their discretion.<br>Observe the station alert system and carry your armaments only as required by the situation, or when authorized by the Head of Security or Captain in exceptional cases.<br>Remember, as an agent of Nanotrasen it is your responsibility to conduct yourself appropriately and you will be held to the highest standard. You will be held accountable for your actions. Security is authorized to search, interrogate or detain you as required by their own procedures. Lawyers will also monitor and observe your conduct, and their mandate applies equally to security and Blueshield operations." |
Contributor
There was a problem hiding this comment.
На остальные темы душить не буду, но эту хуйню локализуй
pilygun
added
the
📜 Локализация
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что этот ПР делает
Переделывает АВД в адвоката, убирая ненужную часть про слежку за соблюдением СРП и превращая его в роль без МЩ (может стать минором, не может стать мажором)
Почему это хорошо для игры
Эксперименты это круто. Нынешний АВД это бумагомарака бесполезный, выпиливать его не хотят, так хоть будет помогать зекам до, во и после тюремного заключения. + смена меты, ведь все привыкли что авд это пассивный игрок который нихуя не может
СРП будет переписано совместно с глав викиредом если эксперимент одобрен
Демонстрация изменений
Демонстрации изменений
Тестирование
Запустил побегал что проебал пофиксил