bugfix/refactor: Logging and error handler improve#8562
Open
littleboobs wants to merge 3 commits intoss220-space:master220from
Open
bugfix/refactor: Logging and error handler improve#8562littleboobs wants to merge 3 commits intoss220-space:master220from
littleboobs wants to merge 3 commits intoss220-space:master220from
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the logging and error handling system, replacing log_runtime(EXCEPTION(...)) with stack_trace() and CRASH() to enhance stability and debugging. While the refactoring is well-executed, a critical security vulnerability exists in the law_manager.dm module where player-controlled silicon mobs can introduce Stored Cross-Site Scripting (XSS) via raw HTML input. The log_world proc also presents a risk of Log Injection and XSS due to its use of html_decode before logging. Additionally, consider refactoring duplicated code in code/datums/spawners_menu.dm:54-57 for improved readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Первоначальный ПР - #8369
Что этот ПР делает
DebugandDebug2all haildebugging_enabledtgstation/tgstation#94002stack_traces, который не давал вывода, потому что сам рантаймил.log_runtime(EXCEPTION())наstack_tracesиCRASH.WARNING. Часть из них я уже заменял раннее, когда портировал юнит тесты, потому что они совершенно бессмысленно рантаймили. Локалка на фастлоуде больше не засирается 7 рантаймами с нулевой.После восстановления:
Замена всех
throw EXCEPTIONнаCRASH