bugfix/refactor: Chat fix#8564
Open
littleboobs wants to merge 2 commits intoss220-space:master220from
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors chat-related code. However, it introduces significant security regressions, specifically Cross-Site Scripting (XSS) vulnerabilities. These arise from the removal of HTML encoding for job titles in AI tracking links and the failure to sanitize speaker names in the refactored colorize_name procedure. Beyond security, there are also recommendations for improving code readability and style guide adherence, such as a style guide violation in code/modules/mob/hear_say.dm concerning conditional operators and a missing comment for a 'magic number' in the normalize_char_code() procedure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что этот ПР делает
Ссылки снова в самом начале любых сообщений. Костыли убраны, нейрослоп насёр тоже. Небольшой рефактор
colorize_name, разбил на проки, привёл в подобающий вид.Демонстрация изменений
Скрины не прикрепляются.