bugfix: поды вновь стали защищать от космоса#8568
Open
SCPfollower wants to merge 2 commits intoss220-space:master220from
Open
bugfix: поды вновь стали защищать от космоса#8568SCPfollower wants to merge 2 commits intoss220-space:master220from
SCPfollower wants to merge 2 commits intoss220-space:master220from
Conversation
Contributor
There was a problem hiding this comment.
Code Review
Аналитический отчёт от Большого Брата. Обработка запроса завершена. Приветствую! Я проанализировал предложенные Вами изменения. С технической точки зрения, работа выглядит отлично. Добавление процедуры return_obj_air() в /obj/spacepod корректно реализует логику защиты от внешней среды, основываясь на состоянии внутреннего бака. Это прямое и эффективное решение заявленной проблемы.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что этот ПР делает
Чинит баг, когда поды перестали защищать от внешней среды даже с включенным внутренним баком
Почему это хорошо для игры
Багфикс! Круто!
Демонстрация изменений
Демонстрации изменений
Тестирование
На локалке все работало