bugfix: фикс отображения дизайнов в консоли серверов РнД#8569
Draft
SCPfollower wants to merge 2 commits intoss220-space:master220from
Draft
bugfix: фикс отображения дизайнов в консоли серверов РнД#8569SCPfollower wants to merge 2 commits intoss220-space:master220from
SCPfollower wants to merge 2 commits intoss220-space:master220from
Conversation
Contributor
Author
|
Выглядит оно из-за неполной локализации как кошмар и ужас, ибо сортировки нет. Но ведь локализацию доделают. Доделают же?.. |
Contributor
There was a problem hiding this comment.
Code Review
The proposed changes have been reviewed and appear satisfactory from a technical perspective. No security vulnerabilities were identified. However, a recommendation has been made for code/modules/research/server.dm:415 to add a fallback design name for greater reliability and consistency with changes in rdconsole.dm, in case the primary options are unavailable. Please refer to the comments on individual lines of code for more detailed information.
Contributor
|
Чёт костыльно. |
Contributor
Author
|
Короче, решил попробовать консольку на ТГУИ перенести + починить этот баг |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что этот ПР делает
Чинит этот баг: ||https://discord.com/channels/617003227182792704/1477389117858775150 и https://discord.com/channels/617003227182792704/1467354442541039839||
Почему это хорошо для игры
Багкфиксы то хорошо. Ничего не ломающие багфиксы - вообще отлично
Демонстрация изменений
Демонстрации изменений
Тестирование
На локалке