Fixed bug that broke installing without kwargs#15
Open
TylerSchroederWM wants to merge 1 commit intossbc:masterfrom
Open
Fixed bug that broke installing without kwargs#15TylerSchroederWM wants to merge 1 commit intossbc:masterfrom
TylerSchroederWM wants to merge 1 commit intossbc:masterfrom
Conversation
Author
|
It appears that this simple fix breaks plugins further down the line. Looking further into it. |
Author
|
On further investigation, the breaks in the second post were caused by the npm version not having this commit pushed yet. The initial fix works fine on a fresh install of ssb-server with the most recent version of ssb-plugins pulled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all available documentation sources, the CLI for ssb-plugins is given as
sbot plugins.install plugin-nameHowever, on Ubuntu 20.04.41 and with muxrpcli 3.1.2, this will throw an error of the form
This is because install/uninstall commands assume
_optsis not undefined, while on muxrpcli 3.1.2, _opts will be undefined if no keyword args are passed.The problem is fixed simply by setting _opts to an empty object if it is undefined.