Skip to content

Add test coverage for ERA5 wind data with height dimension (Issue #66)#102

Open
munniomer wants to merge 1 commit intomainfrom
issue-66-wind-height
Open

Add test coverage for ERA5 wind data with height dimension (Issue #66)#102
munniomer wants to merge 1 commit intomainfrom
issue-66-wind-height

Conversation

@munniomer
Copy link
Collaborator

This PR adds test coverage to ensure that preprocessing works correctly for standard ERA5 wind data containing an additional height dimension.

The test verifies that the height dimension is preserved and remains unaffected by the preprocessing steps, while the existing spatial and temporal processing behaves as expected.

This aligns the preprocessing pipeline with standard ERA5 (non-LAND) NetCDF files where wind variables include a vertical dimension.

Closes #66.

@munniomer munniomer self-assigned this Feb 10, 2026
@sonarqubecloud
Copy link

@munniomer munniomer requested a review from iulusoy February 10, 2026 16:12
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.76%. Comparing base (3bfea3c) to head (544f9b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files           9        9           
  Lines        2405     2422   +17     
=======================================
+ Hits         2375     2392   +17     
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@iulusoy iulusoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment at the line

org_data = dataset["u10"].values.copy()

# no preprocessing step should touch the "height" coordinate
settings = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your approach here, that you test if wind can be included in the data through the unit tests. But,
I think it would be more robust if the preprocessing steps would be set to True for the different options one by one and check that this does not affect the height coordinate. So I suggest to expand the test a bit with different settings dictionaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test that data processing also works with wind data in the netcdf file

2 participants