Add test coverage for ERA5 wind data with height dimension (Issue #66)#102
Open
Add test coverage for ERA5 wind data with height dimension (Issue #66)#102
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 98.75% 98.76%
=======================================
Files 9 9
Lines 2405 2422 +17
=======================================
+ Hits 2375 2392 +17
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iulusoy
requested changes
Feb 12, 2026
| org_data = dataset["u10"].values.copy() | ||
|
|
||
| # no preprocessing step should touch the "height" coordinate | ||
| settings = { |
Member
There was a problem hiding this comment.
I like your approach here, that you test if wind can be included in the data through the unit tests. But,
I think it would be more robust if the preprocessing steps would be set to True for the different options one by one and check that this does not affect the height coordinate. So I suggest to expand the test a bit with different settings dictionaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR adds test coverage to ensure that preprocessing works correctly for standard ERA5 wind data containing an additional
heightdimension.The test verifies that the
heightdimension is preserved and remains unaffected by the preprocessing steps, while the existing spatial and temporal processing behaves as expected.This aligns the preprocessing pipeline with standard ERA5 (non-LAND) NetCDF files where wind variables include a vertical dimension.
Closes #66.