Cleanup Nationality Statsviewer Code #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use MiniDemonWithPlayers everywhere. It's true that a demon will have at most one publisher or verifier, but having a whole new type just to avoid allocating a Vec is a bit much. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Instead of repeating all the fields of a MinimalDemon, just reuse that struct. This brings the structure of MiniDemonWithPlayers closer to MinimalRecordD, its equivalent from the GET /players/[id] endpoint. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
This also brings it closer to MinimalRecordD, its rough equivalent from the FullPlayer object. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Again, to make these structs be more similar to FullPlayer Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Literally every callsite was either explicitly passing in the permalink, or passing it in if some other link was null (e.g. no verification video). So just move this as a default into the function itself. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 30.44% 30.41% -0.04%
==========================================
Files 114 114
Lines 8011 8019 +8
==========================================
Hits 2439 2439
- Misses 5572 5580 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #211 I noticed how absolutely horrendous the nation stats viewer code is, both backend and frontend. Luckily, I never committed to this API by documenting it, so we're free to whack it into shape without regard for backward compatibility.
License Acceptance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.