Skip to content

Conversation

@sphericle
Copy link
Contributor

Adding the functionality of #211 to all sections on the stats viewer

Closes #236

License Acceptance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.16%. Comparing base (38b486c) to head (27885e5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   30.16%   30.16%           
=======================================
  Files         118      118           
  Lines        8121     8121           
=======================================
  Hits         2450     2450           
  Misses       5671     5671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sphericle sphericle marked this pull request as draft April 3, 2025 00:35
@sphericle
Copy link
Contributor Author

sphericle commented Apr 3, 2025

Ok yeah this should be good now.

Btw while testing this, I found something interesting: I added non-100% records to a demon under a player whose nationality is the US...
image

... but these records don't show up under the US nationality in the stats viewer:
image

it seems to work on the actual demonlist (but is also broken on my main branch, so I don't think I broke anything lol) so I'm not gonna worry about it, but I just thought it was worth mentioning

@sphericle sphericle marked this pull request as ready for review April 3, 2025 01:36
@stadust
Copy link
Owner

stadust commented Apr 4, 2025

Thanks! I'll have a closer look at this once I'm back home next week - feel free to ping me if I don't get back to you by next weekend though (cuz that probably means I'll've forgotten 💀)

@stadust
Copy link
Owner

stadust commented Apr 12, 2025

When I click on a nation in the nation stats viewer, I get a TypeError: r1.name is undefined in sortStatsViewerRow() (statsviewer.js:197)

sortStatsViewerRow (http://127.0.0.1:1971/static/demonlist/js/modules/statsviewer.js#197)
sortStatsViewerRow (http://127.0.0.1:1971/static/demonlist/js/modules/statsviewer.js#194)
onReceive (http://127.0.0.1:1971/static/demonlist/js/statsviewer/nation.js#121)
selectArbitrary (http://127.0.0.1:1971/static/core/js/modules/form.js#496)
onSelect (http://127.0.0.1:1971/static/core/js/modules/form.js#513)
handleResponse (http://127.0.0.1:1971/static/core/js/modules/form.js#564)

@sphericle
Copy link
Contributor Author

uhhh? weird i'll look at it soon. i thought i tested all the rows lol 😭

@sphericle
Copy link
Contributor Author

hey, sorry about the inactivity here and on #241, spring break happened shortly after i opened this, and then i was dealing with a lot of AREDL stuff lol. i can take a look at the error you posted later today 🙏

@sphericle
Copy link
Contributor Author

sphericle commented May 8, 2025

should be fixed. thanks for reporting, hopefully this is good now :)

@stadust
Copy link
Owner

stadust commented May 9, 2025

Wohoo, thanks for having a look, I'll try to get back to this PR this weekend!

@stadust
Copy link
Owner

stadust commented May 23, 2025

Sorry for taking so long to get back to this, but I can confirm everything works now. Thanks!

@stadust stadust merged commit ecfbd16 into stadust:master May 23, 2025
4 checks passed
@sphericle sphericle deleted the statsviewer-sort-fix branch December 22, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort unbeaten levels on nations by position when sorting by postition

2 participants