Include statsviewer rank in GET /players/ responses #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
still needs some testing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 30.17% 32.10% +1.93%
==========================================
Files 118 118
Lines 8119 8123 +4
==========================================
+ Hits 2450 2608 +158
+ Misses 5669 5515 -154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allow us to add player ranks to the FullPlayer objects, which will simplify the stats viewer frontend significantly. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
It needs to be refreshed whenever someone's score changes. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
I thought that deletes on the players table might get messed up because the materialized view has an index, but seems like this is not the case. Good to have a simple test for the merging functionality anyway though. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
This will include it in all pagination responses (we already join with the nationalities table, so surely this can't be that bad), but more importantly, we return it in the GET for individual players, which allows us to simplify the stats viewer a bit. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
stadust
force-pushed
the
cached-player-ranks
branch
from
af1695d to
9d8f3fc
Compare
With both scores and ranks cached these days, the individual stats viewer can stop parsing them from the html of the selection panel, and instead just grab them from the API response. This means that now the individual stats viewer actually supports .selectArbitrary for selecting players not currently visible in the pagination panel. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a materialized view to cache the ranking, refresh it when appropriate, and use that to return a player's rank as part of GET /players/ responses (both pagination and normal). Will help with implementing #241
License Acceptance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.