Small overview page QoL improvements #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logged in, make the player claimed by the logged in user available to the demonlist overview page. Explicitly do not require a verified claim. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
This way it's easier to access the claimed player. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
- Stop it being italic - Add a "published by" text - make name a statsviewer link Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Add the minimal possible score (for meeting list%) and total possible score to the overview page. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Similar to what demonlist+ is doing, display the progress of the player claimed by the logged in user on the right hand side. Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
It just doesnt fit width-wise Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 32.16% 32.07% -0.10%
==========================================
Files 118 118
Lines 8133 8157 +24
==========================================
Hits 2616 2616
- Misses 5517 5541 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With player claims being mostly in place, and google oauth at least saving us from "I forgot my password", we can start implementing some much requested features traditionally home to the demonlist+ extension into pointercrate itself. For starters, this PR implements the "progress on overview" stuff, based on player claims (the claim does not need to be verified for this).
License Acceptance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.