new ru translation fix #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, we have authenticated and unauthenticated variants of the same endpoint, with the implicit assumption that if a request had no authentication information (e.g. headers, cookies, whatevs), then rocket would pick the unauthenticated one. However, this only worked if the FromRequest impl for Auth<T> actually forwarded instead of returning an Unauthorized error on missing authentication information (as rocket will abort request processing when Outcome::Error is returned). Yet, this was not the case. While we are at it, forward with the correct status code (unauthorized instead of not found) Closes stadust#270 Signed-off-by: stadust <43299462+stadust@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 35.06% 35.06%
=======================================
Files 121 121
Lines 6188 6188
=======================================
Hits 2170 2170
Misses 4018 4018 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License Acceptance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
no idea where tf the other 2 commits came from lol