WIP: Add image download button #242
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For most workflows the "Copy image" button is all we need, but sometimes (especially for my half-baked, half-automated QA process that I'm working on for one of our clients) I want to download the screenshot instead of save it to the clipboard. I can do that now, but it takes a few extra steps (open Preview, ⌘N to create new image from clipboard, then save the file, manually copying useful information into the filename).
This PR adds a new button (unlabeled to safe space, with just a download icon) next to the screenshot icon, that saves the current map view to a file and adds the zoom and lat/lng to the filename. It somewhat streamlines my workflow.
I renamed the existing
downloadScreenshotfunction tocopyScreenshotToClipboard, and my new function uses the olddownloadScreenshotname. But currently they're duplicating most of the code, which isn't great.In the longer term I'd like to think about how to hook this up to a list of QA locations in the gazetteer and download several of them all at once, and probably also have the gazetteer define a prefix to use for the downloaded images.
Author checklist
Create the PR
After approval
maininto your branch, resolve any conflictsmain