Skip to content

Fixing style on the Functions notes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
parthsarin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing style on the Functions notes #1

parthsarin wants to merge 2 commits into from

Conversation

@parthsarin
Copy link
Member

@parthsarin parthsarin commented Aug 22, 2020 •
edited
Loading

  • Removed all if __name__ == '__main__' statements.
  • Reordered so that all code blocks are called out before they're initiated and that we aren't describing a code block before it's introduced.
  • Removed italicized terms in definitions.
  • Changed the signature to the one that I've been using for the other set of notes (With love and 🦄s by @psarin and @coopermj) – @cooper-mj did you want to change this??

@parthsarin parthsarin marked this pull request as draft August 22, 2020 03:47
@parthsarin parthsarin requested a review from cooper-mj August 22, 2020 03:49
@parthsarin parthsarin marked this pull request as ready for review August 22, 2020 03:49
@cooper-mj
Copy link
Member

cooper-mj commented Aug 23, 2020

This all sounds perfectly sensible - planning to take some time tomorrow to review in person before approving the merge, but I don't expect any problems.

@parthsarin
Copy link
Member Author

parthsarin commented Mar 12, 2021

How was that review, @cooper-mj?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooper-mj cooper-mj Awaiting requested review from cooper-mj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthsarin @cooper-mj