Skip to content

fasthtml: use attribute generators in examples #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gazpachoking merged 2 commits into from
Dec 22, 2025
Merged

fasthtml: use attribute generators in examples #29

gazpachoking merged 2 commits into from
Dec 22, 2025

Conversation

@axelknock
Copy link
Contributor

@axelknock axelknock commented Dec 21, 2025

Also disabled live=True in the FastHTML app creation since it was causing some issue with the reload method (websocket) constantly reloading the page. Not sure what the issue is, but it's not a datastar issue. It might be better to just provide an example of Delaney's hotreload method. Here's a rough draft of it using the python SDK:

For it to work correctly:

uvicorn main:app --reload --timeout-graceful-shutdown 0
import asyncio
from starlette.applications import Starlette
from starlette.responses import HTMLResponse
from starlette.requests import Request
from starlette.routing import Route

from datastar_py import ServerSentEventGenerator as SSE
from datastar_py import attribute_generator as data
from datastar_py.starlette import datastar_response


hot_reload_sent = False
hot_reload_lock = asyncio.Lock()


async def index(request: Request):
    return HTMLResponse(
        f"""
        <html>
            <head>
                <script type="module"
                    src="https://cdn.jsdelivr.net/gh/starfederation/datastar@v1.0.0-RC.7/bundles/datastar.js">
                </script>
            </head>
            <body>
                <div>Hello world!</div>
                <div id="hotreload"
                     {data.init("@get('/hotreload', {retryMaxCount: 1000, retryInterval: 20, retryMaxWaitMs: 200})")}>
                </div>
            </body>
        </html>
        """
    )


@datastar_response
async def hotreload(request: Request):
    global hot_reload_sent

    async with hot_reload_lock:
        if not hot_reload_sent:
            hot_reload_sent = True
            yield SSE.execute_script("window.location.reload()")

    while not await request.is_disconnected():
        await asyncio.sleep(0.5)


app = Starlette(
    routes=[
        Route("/", index),
        Route("/hotreload", hotreload),
    ]
)

gazpachoking
gazpachoking reviewed Dec 21, 2025
View reviewed changes
@gazpachoking gazpachoking merged commit 28d6472 into starfederation:develop Dec 22, 2025
1 of 2 checks passed
@gazpachoking
Copy link
Collaborator

gazpachoking commented Dec 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gazpachoking gazpachoking gazpachoking left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axelknock @gazpachoking