fix(types): Datum.toComponent() should return ReactElement instead of Component#167
Open
Josh-Cena wants to merge 1 commit intostaylor:mainfrom
Open
fix(types): Datum.toComponent() should return ReactElement instead of Component#167Josh-Cena wants to merge 1 commit intostaylor:mainfrom
Josh-Cena wants to merge 1 commit intostaylor:mainfrom
Conversation
Author
|
@staylor Could you take a look at this, please? |
khmm12
approved these changes
May 27, 2022
|
FWIW the same fix was made to |
Author
|
It's been two years and after the types refactor the bug is still actual. @staylor? |
|
I've also it this. Would be nice if it could be fixed. I wonder if the method's name should also change though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React.Componentis something likefunction Comp() {...}orclass Comp extends Component, whileReact.ReactElementis like<Comp />, the "return value" of a component. This has blocked me from doing something likeReact.Children.toArray(datum).