Log when the context does not exist instead of throwing errors#193
Open
strmer15 wants to merge 3 commits intostaylor:mainfrom
Open
Log when the context does not exist instead of throwing errors#193strmer15 wants to merge 3 commits intostaylor:mainfrom
strmer15 wants to merge 3 commits intostaylor:mainfrom
Conversation
Author
|
@staylor Could you review this and let me know if it can make into the next release? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were switching from
react-helmettoreact-helmet-async, but our production application threw errors at runtime (effectively shutting our website down) because of a misplaced<Helmet>tag outside of the<HelmetProvider>. This causedreact-helmet-asyncto throw the errorCannot read properties of undefined (reading 'add').While that's an obvious problem that can be addressed separately, it would help users who are switching to check for a missing context beforehand and not attempt to reference objects that are possibly
undefined. This change checks to see ifhelmetInstancesis truthy and, if not, logs a trace to the console and returns immediately. This way, users can be aware of their code not behaving correctly while still maintaining a running website.