events in scripts as reference and not render it as string#203
Open
eduardocque wants to merge 1 commit intostaylor:mainfrom
Open
events in scripts as reference and not render it as string#203eduardocque wants to merge 1 commit intostaylor:mainfrom
eduardocque wants to merge 1 commit intostaylor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #202 one of the issues seems to be that we are trying to set onload as string using setAttribute and based on https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute#value will save it as string making this can lose the context in some cases or triggering the wrong references
this probably is not perfect but if require any change, let me know