Change package.json to type: "module", fix commitlint module export error#230
Open
geyang wants to merge 3 commits intostaylor:mainfrom
Open
Change package.json to type: "module", fix commitlint module export error#230geyang wants to merge 3 commits intostaylor:mainfrom
geyang wants to merge 3 commits intostaylor:mainfrom
Conversation
|
@geyang: Does |
This was referenced Aug 28, 2024
|
Thinking about it, I think this would be a breaking change, as I don't think CommonJS modules would be able to import this package any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the module type issue #208
Mainly:
type: "module"to package.json so that it works with vite projects without needing the cjs interpolation. In vite, the cjs interpolate does not work consistently when we switch between preview, build, and SSR in dev modes.mainto"index.esm.js"according to this comment.type="module", the commitlint export is faulty. Change the.jspostfix to.cjsto fix module resolution error.@staylor let me know if there are issues you want me to address.