Skip to content

Conversation

@leighmcculloch
Copy link
Member

What

Add image name and revision tracking to persistent volumes. Save version metadata to .quickstart-version.json on first initialization. Display a warning when the running container version differs from the version that initialized the volume. Pass image name as a build argument through the CI pipeline so that the full image name can be shown.

Why

Persistent volumes may contain incompatible data when used across different quickstart versions.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds version tracking to persistent volumes to help prevent data incompatibility issues. When a quickstart container starts, it checks if the persistent volume was initialized with a different version and displays a warning if there's a mismatch.

Changes:

  • Added version validation function that warns users when persistent volume version differs from running container version
  • Modified build process to pass image name through CI pipeline as a build argument
  • Version metadata is saved to .quickstart-version.json on first initialization

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
start Added validate_persistent_volume_version() function to check for version mismatches and modified copy_defaults() to save version information on first initialization
Dockerfile Added IMAGE_NAME build argument and environment variable to track the full image name
.github/workflows/internal-build.yml Added tag-prefix input parameter and passed IMAGE_NAME build argument with proper tag prefix
.github/workflows/ci.yml Passed tag-prefix output from setup job to build workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leighmcculloch leighmcculloch marked this pull request as ready for review January 12, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog (Not Ready)

Development

Successfully merging this pull request may close these issues.

2 participants