-
Notifications
You must be signed in to change notification settings - Fork 226
Add version validation for persistent volumes #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds version tracking to persistent volumes to help prevent data incompatibility issues. When a quickstart container starts, it checks if the persistent volume was initialized with a different version and displays a warning if there's a mismatch.
Changes:
- Added version validation function that warns users when persistent volume version differs from running container version
- Modified build process to pass image name through CI pipeline as a build argument
- Version metadata is saved to
.quickstart-version.jsonon first initialization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| start | Added validate_persistent_volume_version() function to check for version mismatches and modified copy_defaults() to save version information on first initialization |
| Dockerfile | Added IMAGE_NAME build argument and environment variable to track the full image name |
| .github/workflows/internal-build.yml | Added tag-prefix input parameter and passed IMAGE_NAME build argument with proper tag prefix |
| .github/workflows/ci.yml | Passed tag-prefix output from setup job to build workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What
Add image name and revision tracking to persistent volumes. Save version metadata to
.quickstart-version.jsonon first initialization. Display a warning when the running container version differs from the version that initialized the volume. Pass image name as a build argument through the CI pipeline so that the full image name can be shown.Why
Persistent volumes may contain incompatible data when used across different quickstart versions.