Refactor test-layer-positioning.R to eliminate code duplication#164
Merged
stemangiola merged 2 commits intofix-layersfrom Jan 14, 2026
Merged
Refactor test-layer-positioning.R to eliminate code duplication#164stemangiola merged 2 commits intofix-layersfrom
stemangiola merged 2 commits intofix-layersfrom
Conversation
Co-authored-by: stemangiola <7232890+stemangiola@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix positioning bug in layer_symbol and layer_text functions
Refactor test-layer-positioning.R to eliminate code duplication
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test file contained duplicated
dummy_dfcreation code in two test cases (lines 13-31 and 89-107), both constructing identical test data from GitHub issue #162.Changes
create_issue_162_dummy_df()helper function to encapsulate shared test data💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Note
Streamlines test setup for layer positioning validations while keeping assertions and visuals intact.
create_issue_162_dummy_df()helper intests/testthat/test-layer-positioning.Rtibbleconstruction in two tests with the helper (layer_asteriskposition and visual tests)vdiffrsnapshot, reducing duplication and lines of codeWritten by Cursor Bugbot for commit 7c2bbcf. This will update automatically on new commits. Configure here.