Fix GIF uploading bug #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, one usually has to upload the gif multiple times before it's properly applied to the stage. This fixes the relevant bugs preventing it from uploading correctly the first time. 1) Reserve memory to avoid multiple allocations in ReadBytes 2) Reorganize skip-past-end-of-data method in ReadLZWCode 3) Expand method to clear the dictionary in LWZDecoder::DecodeImage() 4) Use a std::array instead of a raw array 5) Initialize the array with zeros 6) Use data() to get the pointer of the packet data in CreateUploadPackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, one usually has to upload the gif multiple times before it's properly applied to the stage (at least with Gen4/Gen5, this is a commonly known issue - not sure if earlier model stages are affected?). This fixes the relevant bugs preventing it from uploading correctly the first time.
ReadBytesReadLZWCodeLWZDecoder::DecodeImage()std::arrayinstead of a raw arraydata()to get the pointer of the packet data inCreateUploadPackets