Open
Conversation
Errors are handled in similar way as messages - through block handler. Original xpc_object_t object is passed through, so user can check what kind of error it is (i.e. XPC_ERROR_CONNECTION_INTERRUPTED etc). Second parameter is user friendly description retrieved from the error object via xpc_dictionary_get_string() function and lastly the connection itself.
|
Instead of the if/else preprocessor directives, consider macros like this: ... and so on. This way, one macro controls everything and can be modified accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I've adopted XPCKit to my app and it's been really smooth sailing so far (much smoother then using XPC API directly, not to mention clearer code etc). Gladly I've code across your lib as I was about to write my own (not nearly as sophisticated, just to cover my needs). Anyway, I added two things which I use in my app:
XPCConnectionthat's invoked when an error is detected. Also updated TestApp to demonstrate how it can be used.If you think this would be useful for other users, feel free to merge into main repo, otherwise just close the pull request :)
Thanks for the lib! Tom