(Closes #3234 and #3232) Conditionally compiled openmp support #3235
+112
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonelyCat124
added
the
Blocked
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3235 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 375 375
Lines 53434 53449 +15
=======================================
+ Hits 53379 53394 +15
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LonelyCat124
changed the title
LonelyCat124
changed the title
Collaborator
Author
|
Also fixed the typos from #3232. |
LonelyCat124
added
ready for review
and removed
Blocked
Collaborator
|
It looks good @LonelyCat124 , there is only some minor docstring ajustments that I will do myself. I submited the Integration tests but there are pending jobs and a PR pending to be merge, so I will finish checking things tomorrow. |
sergisiso
approved these changes
Dec 2, 2025
Collaborator
sergisiso
left a comment
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 Everything suceeded, this is approved for merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on #3196 so on hold for review until that is merged.
Happy to change the option name here, just put something together to get it up and running.