-
Notifications
You must be signed in to change notification settings - Fork 33
(closes #3243) Unify and document nemo scritps #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ation' into single_nemo_script
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3244 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 376 376
Lines 53485 53499 +14
=======================================
+ Hits 53463 53477 +14
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@LonelyCat124 This is ready for another review |
bc5d55f to
1fc199e
Compare
|
@LonelyCat124 This is now ready for another look, (you will see that I submited a few integration tests that failed, so I force-pused a removal of these last commits), the integration of the current commit is successful. The slowdown for OpenACC loops is necessary to have full numberical reproducibility, before it was tested with a tolerance, but this can hide small issues, so I prefer to be strict on this even if we lose performance. |
|
@sergisiso Can you fix up the conflicts that have appeared and I'll review this again - I can't view them in the web editor annoyingly as I suspect that may end up being copyright changes but I'm not sure. |
Uh oh!
There was an error while loading. Please reload this page.