Skip to content

Conversation

@sergisiso
Copy link
Collaborator

@sergisiso sergisiso commented Dec 2, 2025

  • Unifies omp_gpu_trans.py omp_cpu_trans.py and acc_loops_trans.py
  • Adds a new README (https://github.com/stfc/PSyclone/tree/single_nemo_script/examples/nemo/scripts)
  • Switch one of the NEMOv5 ORCA test from OpenMP to OpenACC loops to have coverage of both
  • Improve performance of NEMOv5 (NEMOv4 got a regression needed to get full reproducibility)
  • Require full reproducibility of remaining nemo (loop) tests

sergisiso and others added 26 commits October 15, 2025 10:10
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (ee25f8a) to head (d1dba5a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3244   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         376      376           
  Lines       53485    53499   +14     
=======================================
+ Hits        53463    53477   +14     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso
Copy link
Collaborator Author

@LonelyCat124 This is ready for another review

@sergisiso
Copy link
Collaborator Author

@LonelyCat124 This is now ready for another look, (you will see that I submited a few integration tests that failed, so I force-pused a removal of these last commits), the integration of the current commit is successful.

The slowdown for OpenACC loops is necessary to have full numberical reproducibility, before it was tested with a tolerance, but this can hide small issues, so I prefer to be strict on this even if we lose performance.

@LonelyCat124
Copy link
Collaborator

@sergisiso Can you fix up the conflicts that have appeared and I'll review this again - I can't view them in the web editor annoyingly as I suspect that may end up being copyright changes but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants