Draft: Add locking #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2024 13:53
This might be useful to prevent data loss/corruption when we have simultaneous transfers of the same file. We do the locking in the following way: locks are added on a separate object with the name <file_name>.<lock_name>, where <lock_name> is different from file's object numbers (it is basically a text string). On lock release, this object is removed. We use this awkward tecnique instead of locking the first object for the following reason: radosstriper does not like when he tries to create a new file, and its first object already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be useful to prevent data loss/corruption when we have simultaneous transfers of the same file.
We do the locking in the following way: lock is added to a separate object with the name <file_name>.<lock_name>, where <lock_name> is different from file's object numbers (it is basically a text string). On lock release, this object is removed. We use this ugly technique instead of locking the first object for the following reason: radosstriper does not like when it tries to create a new file and its first object already exists.