Move the operator argument for Operation and wrap it in Node#247
Open
jfmengels wants to merge 45 commits intobreaking-changes-v8from
Open
Move the operator argument for Operation and wrap it in Node#247jfmengels wants to merge 45 commits intobreaking-changes-v8from
jfmengels wants to merge 45 commits intobreaking-changes-v8from
Conversation
jfmengels
commented
Aug 3, 2024
| symbol | ||
| ) | ||
| (Parser.symbol symbol) | ||
| |= Parser.getPosition |
Collaborator
Author
There was a problem hiding this comment.
(I'm slightly happy with this trick that avoids an eager getPosition)
jfmengels
force-pushed
the
breaking-changes-v8
branch
from
eff82e1 to
0f43132
Compare
jfmengels
force-pushed
the
breaking-changes-v8
branch
2 times, most recently
from
7ccc635 to
1787a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping it in a Node makes the position available, which I know we've used workarounds for in some
elm-reviewrules.Moving the operator is meant to make the data resemble the AST more (because it's
a + b, not+ a b)I'm not sure if we can improve the parser part more.