Remove predicate functions from Expression#249
Open
jfmengels wants to merge 44 commits intobreaking-changes-v8from
Open
Remove predicate functions from Expression#249jfmengels wants to merge 44 commits intobreaking-changes-v8from
jfmengels wants to merge 44 commits intobreaking-changes-v8from
Conversation
jfmengels
force-pushed
the
breaking-changes-v8
branch
from
eff82e1 to
0f43132
Compare
jfmengels
force-pushed
the
remove-expression-helpers
branch
from
829a0fd to
b9e532a
Compare
jfmengels
force-pushed
the
breaking-changes-v8
branch
2 times, most recently
from
7ccc635 to
1787a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package is very much oriented towards using pattern matching, and I feel that these functions go against that idea. We should either do none, or do a lot more (for every node type?).
I'mp pretty sure all these functions (and more helper functions in the package) were meant to help with a very specific use-case in Elm Analyse. In this case, it was https://github.com/stil4m/elm-analyse/blob/701b8b4013a4f057b9382d368e42adc6fe08e14e/src/Analyser/Checks/UnnecessaryParens.elm#L196
I think these helper functions are likely better reimplemented in the usage code.