Open
Conversation
jfmengels
force-pushed
the
breaking-changes-v8
branch
from
eff82e1 to
0f43132
Compare
jfmengels
force-pushed
the
remove-port-module
branch
from
dcd8713 to
dacac82
Compare
jfmengels
force-pushed
the
breaking-changes-v8
branch
2 times, most recently
from
7ccc635 to
1787a7f
Compare
jfmengels
force-pushed
the
remove-port-module
branch
from
dacac82 to
28575a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like this module is a bit overkill. I don't know if we should have a type alias for
PortinsideElm.Syntax.Declaration, or just inline the record (like what I did here).A type alias makes it easier to add type annotations for these values should they need to be annotated, but it also adds indirection and makes it harder to know what data is available and under which name.
(If merged, I might squash this with the commit that introduced the module, as this was done in the
breaking-changes-v8branch)