Skip to content

fix: use themed colors in actions panel for dark mode support #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannyhw merged 2 commits into from
Feb 28, 2026
Merged

fix: use themed colors in actions panel for dark mode support #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d18a6
fix: use themed colors in actions panel for dark mode support
dannyhw Feb 28, 2026
e12e4cf
changeset
dannyhw Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-buttons-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@storybook/addon-ondevice-actions': patch
---

fix actions logs not themed
1 change: 1 addition & 0 deletions packages/ondevice-actions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"check:types": "tsc --noEmit"
},
"dependencies": {
"@storybook/react-native-theming": "^10.3.0-next.2",
"fast-deep-equal": "^3.1.3"
},
"devDependencies": {
Expand Down
104 changes: 54 additions & 50 deletions packages/ondevice-actions/src/components/ActionLogger/Inspect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,39 @@
import React, { useState } from 'react';
import { View, Text, StyleSheet, TouchableOpacity } from 'react-native';

const theme = {
OBJECT_NAME_COLOR: 'rgb(136, 19, 145)',
OBJECT_VALUE_NULL_COLOR: 'rgb(128, 128, 128)',
OBJECT_VALUE_UNDEFINED_COLOR: 'rgb(128, 128, 128)',
OBJECT_VALUE_REGEXP_COLOR: 'rgb(196, 26, 22)',
OBJECT_VALUE_STRING_COLOR: 'rgb(196, 26, 22)',
OBJECT_VALUE_SYMBOL_COLOR: 'rgb(196, 26, 22)',
OBJECT_VALUE_NUMBER_COLOR: 'rgb(28, 0, 207)',
OBJECT_VALUE_BOOLEAN_COLOR: 'rgb(28, 0, 207)',
OBJECT_VALUE_FUNCTION_PREFIX_COLOR: 'rgb(13, 34, 170)',

ARROW_COLOR: '#859499',
};
import { View, StyleSheet, TouchableOpacity } from 'react-native';
import { styled } from '@storybook/react-native-theming';

const DefaultText = styled.Text(({ theme }) => ({
color: theme.color.defaultText,
}));

const ObjectNameText = styled.Text(({ theme }) => ({
color: theme.color.secondary,
}));

const MutedText = styled.Text(({ theme }) => ({
color: theme.textMutedColor,
}));

const StringText = styled.Text(({ theme }) => ({
color: theme.color.orange,
}));

const NumberText = styled.Text(({ theme }) => ({
color: theme.color.green,
}));

const BooleanText = styled.Text(({ theme }) => ({
color: theme.color.seafoam,
}));

const FunctionText = styled.Text(({ theme }) => ({
color: theme.color.purple,
}));

const ArrowText = styled.Text<{ visible: boolean }>(({ theme, visible }) => ({
color: visible ? theme.textMutedColor : 'transparent',
paddingRight: 8,
}));

interface InspectProps {
name?: string;
Expand All @@ -32,15 +52,9 @@ const Inspect = ({ name, value }: InspectProps) => {
}
}, [canExpand]);

const toggle = (
<Text style={{ color: canExpand ? theme.ARROW_COLOR : 'transparent', paddingRight: 8 }}>
{expanded ? '▼' : '▶'}
</Text>
);
const toggle = <ArrowText visible={!!canExpand}>{expanded ? '▼' : '▶'}</ArrowText>;

const nameComponent = name ? (
<Text style={{ color: theme.OBJECT_NAME_COLOR }}>{name}</Text>
) : null;
const nameComponent = name ? <ObjectNameText>{name}</ObjectNameText> : null;

if (Array.isArray(value)) {
if (name) {
Expand All @@ -49,7 +63,7 @@ const Inspect = ({ name, value }: InspectProps) => {
<TouchableOpacity onPress={toggleExpanded} style={styles.row}>
{toggle}
{nameComponent}
<Text>{`: ${value.length === 0 ? '[]' : expanded ? '[' : '[...]'}`}</Text>
<DefaultText>{`: ${value.length === 0 ? '[]' : expanded ? '[' : '[...]'}`}</DefaultText>
</TouchableOpacity>
{expanded ? (
<View style={styles.expanded}>
Expand All @@ -59,7 +73,7 @@ const Inspect = ({ name, value }: InspectProps) => {
</View>
))}
<View style={styles.spacingLeft}>
<Text>]</Text>
<DefaultText>]</DefaultText>
</View>
</View>
) : null}
Expand All @@ -68,13 +82,13 @@ const Inspect = ({ name, value }: InspectProps) => {
}
return (
<>
<Text>[</Text>
<DefaultText>[</DefaultText>
{value.map((v, i) => (
<View key={i} style={styles.spacingLeft}>
<Inspect value={v} />
</View>
))}
<Text>]</Text>
<DefaultText>]</DefaultText>
</>
);
}
Expand All @@ -85,7 +99,7 @@ const Inspect = ({ name, value }: InspectProps) => {
<TouchableOpacity style={styles.row} onPress={toggleExpanded}>
{toggle}
{nameComponent}
<Text>{`: ${Object.keys(value).length === 0 ? '{}' : expanded ? '{' : '{...}'}`}</Text>
<DefaultText>{`: ${Object.keys(value).length === 0 ? '{}' : expanded ? '{' : '{...}'}`}</DefaultText>
</TouchableOpacity>
{expanded ? (
<View style={styles.expanded}>
Expand All @@ -95,7 +109,7 @@ const Inspect = ({ name, value }: InspectProps) => {
</View>
))}
<View style={styles.spacingLeft}>
<Text>{'}'}</Text>
<DefaultText>{'}'}</DefaultText>
</View>
</View>
) : null}
Expand All @@ -104,13 +118,13 @@ const Inspect = ({ name, value }: InspectProps) => {
}
return (
<>
<Text>{'{'}</Text>
<DefaultText>{'{'}</DefaultText>
{Object.entries(value).map(([key, v]) => (
<View key={key}>
<Inspect name={key} value={v} />
</View>
))}
<Text>{'}'}</Text>
<DefaultText>{'}'}</DefaultText>
</>
);
}
Expand All @@ -119,7 +133,7 @@ const Inspect = ({ name, value }: InspectProps) => {
<View style={styles.row}>
{toggle}
{nameComponent}
<Text>: </Text>
<DefaultText>: </DefaultText>
<Value value={value} />
</View>
);
Expand All @@ -129,35 +143,25 @@ const Inspect = ({ name, value }: InspectProps) => {

function Value({ value }: { value: any }) {
if (value === null) {
return <Text style={{ color: theme.OBJECT_VALUE_NULL_COLOR }}>null</Text>;
return <MutedText>null</MutedText>;
}
if (value === undefined) {
return <Text style={{ color: theme.OBJECT_VALUE_UNDEFINED_COLOR }}>undefined</Text>;
return <MutedText>undefined</MutedText>;
}
if (value instanceof RegExp) {
return (
<Text style={{ color: theme.OBJECT_VALUE_REGEXP_COLOR }}>
{`/${value.source}/${value.flags}`}
</Text>
);
return <StringText>{`/${value.source}/${value.flags}`}</StringText>;
}
switch (typeof value) {
case 'string':
return (
<Text style={{ color: theme.OBJECT_VALUE_STRING_COLOR }}>{JSON.stringify(value)}</Text>
);
return <StringText>{JSON.stringify(value)}</StringText>;
case 'number':
return (
<Text style={{ color: theme.OBJECT_VALUE_NUMBER_COLOR }}>{JSON.stringify(value)}</Text>
);
return <NumberText>{JSON.stringify(value)}</NumberText>;
case 'boolean':
return (
<Text style={{ color: theme.OBJECT_VALUE_BOOLEAN_COLOR }}>{JSON.stringify(value)}</Text>
);
return <BooleanText>{JSON.stringify(value)}</BooleanText>;
case 'function':
return <Text style={{ color: theme.OBJECT_VALUE_FUNCTION_PREFIX_COLOR }}>[Function]</Text>;
return <FunctionText>[Function]</FunctionText>;
default:
return <Text>{JSON.stringify(value)}</Text>;
return <DefaultText>{JSON.stringify(value)}</DefaultText>;
}
}

Expand Down
9 changes: 7 additions & 2 deletions packages/ondevice-actions/src/components/ActionLogger/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { ActionDisplay } from 'storybook/actions';
import { Button, ScrollView, StyleSheet, Text, View } from 'react-native';
import { Button, ScrollView, StyleSheet, View } from 'react-native';
import { styled } from '@storybook/react-native-theming';
import Inspect from './Inspect';

const CountText = styled.Text(({ theme }) => ({
color: theme.color.defaultText,
}));

interface ActionLoggerProps {
actions: ActionDisplay[];
onClear: () => void;
Expand All @@ -13,7 +18,7 @@ export const ActionLogger = ({ actions, onClear }: ActionLoggerProps) => (
<View>
{actions.map((action: ActionDisplay) => (
<View key={action.id} style={styles.row}>
<View>{action.count > 1 ? <Text>{action.count}</Text> : null}</View>
<View>{action.count > 1 ? <CountText>{action.count}</CountText> : null}</View>
<View style={styles.grow}>
<Inspect name={action.data.name} value={action.data.args || action.data} />
</View>
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.