Remove "TODO" print when parsing non-ascii characters #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
Contributor
Author
|
Hi, any update on this @oxygen-dioxide? |
Owner
|
@NeffIsBack thanks for contribution! version 0.4.3 released sorry for long response time |
1 task
Contributor
Author
No worries, thanks a lot for the new release and your work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we are using this library on NetExec. Currently i am reviewing a Pull Requests that parses Windows links with your tool and when parsing links that contain non-ascii characters a TODO is printed to stdout:
This PR removes the print, but keeps the comment so you can still read up "unicode stuff" if you would like to :D
A new release to pypi would be highly appreciated, so that we can update our version!