Skip to content

ClickHouse DDL Schema Improvements for Observability #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garysassano wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ClickHouse DDL Schema Improvements for Observability #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20bdb14
fix ddl queries
garysassano Jul 24, 2025
0b656e5
include column types in create mv
garysassano Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bin/clickhouse-ddl/ddl_metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ pub(crate) fn get_metrics_ddl(
("MAP_INDICES", map_indices),
(
"TTL_EXPR",
build_ttl_string(ttl, "toDateTime(TimeUnix)").as_str(),
build_ttl_string(ttl, "TimeUnix").as_str(),
),
("JSON_SETTING", json_setting),
]),
Expand Down
15 changes: 10 additions & 5 deletions src/bin/clickhouse-ddl/ddl_traces.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ pub(crate) fn get_traces_ddl(
("MAP_INDICES", map_indices),
(
"TTL_EXPR",
build_ttl_string(ttl, "toDateTime(Timestamp)").as_str(),
build_ttl_string(ttl, "Timestamp").as_str(),
),
("JSON_SETTING", json_setting),
]),
Expand All @@ -52,7 +52,7 @@ pub(crate) fn get_traces_ddl(
("ENGINE", engine),
(
"TTL_EXPR",
build_ttl_string(ttl, "toDateTime(Start)").as_str(),
build_ttl_string(ttl, "Start").as_str(),
),
]),
);
Expand Down Expand Up @@ -114,7 +114,7 @@ CREATE TABLE IF NOT EXISTS %%TABLE%% %%CLUSTER%% (
INDEX idx_duration Duration TYPE minmax GRANULARITY 1
) ENGINE = %%ENGINE%%
PARTITION BY toDate(Timestamp)
ORDER BY (ServiceName, SpanName, toDateTime(Timestamp))
ORDER BY (ServiceName, SpanName, Timestamp)
%%TTL_EXPR%%
SETTINGS index_granularity = 8192, ttl_only_drop_parts = 1 %%JSON_SETTING%%
;
Expand All @@ -130,8 +130,8 @@ const TRACES_TABLE_MAP_INDICES_SQL: &str = r#"
const TRACES_TABLE_ID_TS_SQL: &str = r#"
CREATE TABLE IF NOT EXISTS %%TABLE%% %%CLUSTER%% (
TraceId String CODEC(ZSTD(1)),
Start DateTime CODEC(Delta, ZSTD(1)),
End DateTime CODEC(Delta, ZSTD(1)),
Start DateTime64(9) CODEC(Delta, ZSTD(1)),
End DateTime64(9) CODEC(Delta, ZSTD(1)),
INDEX idx_trace_id TraceId TYPE bloom_filter(0.01) GRANULARITY 1
) ENGINE = %%ENGINE%%
PARTITION BY toDate(Start)
Expand All @@ -143,6 +143,11 @@ SETTINGS index_granularity = 8192, ttl_only_drop_parts = 1;
const TRACES_TABLE_ID_TS_MV_SQL: &str = r#"
CREATE MATERIALIZED VIEW IF NOT EXISTS %%TABLE%% %%CLUSTER%%
TO %%TABLE_ID_TS%%
(
TraceId String,
Start DateTime64(9),
End DateTime64(9)
)
AS SELECT
TraceId,
min(Timestamp) as Start,
Expand Down