bump otelgrpc, replace removed interceptors#14
Open
fschoell wants to merge 2 commits intostreamingfast:developfrom
Open
bump otelgrpc, replace removed interceptors#14fschoell wants to merge 2 commits intostreamingfast:developfrom
fschoell wants to merge 2 commits intostreamingfast:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the unary and stream interceptors have been deprecated for a while now and been removed in the latest otelgrpc v0.61.0, see open-telemetry/opentelemetry-go-contrib#4534
This creates dependency conflicts with Caddy v2.10.2 for us. So this PR updates it to StatsHandlers instead of interceptors as recommended in the otelgrpc repository. Unfortunately I don't have an open telemetry setup so I wasn't able to test this in more detail, but this seems to be the appropriate way.