Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR introduces JSON schema definitions for a Component Gallery catalog system. The schemas provide structured validation for component submissions and the compiled component catalog.
Changes:
- Added
component.schema.jsonfor validating individual component submission data - Added
compiled.schema.jsonfor validating the compiled components catalog structure - Defined comprehensive validation rules including required fields, format constraints, and category enumerations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| directory/schemas/component.schema.json | Defines schema for component submission with validation for metadata, author info, links, categories, and governance |
| directory/schemas/compiled.schema.json | Defines schema for compiled catalog including metrics, ranking signals, and aggregated component data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sfc-gh-bnisco
force-pushed
the
01-13-_feat_add_jsonschemas
branch
from
a9e06e1 to
91e2fa0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
directory/schemas/component.schema.json:1
- Inconsistent capitalization: 'Github' should be 'GitHub' to match the standard brand name and other references in the schema (e.g., 'gitHubUrl' at line 30, 62).
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sfc-gh-bnisco
force-pushed
the
01-13-_feat_add_jsonschemas
branch
from
91e2fa0 to
a2a0b92
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sfc-gh-bnisco
force-pushed
the
01-13-_feat_add_jsonschemas
branch
from
a2a0b92 to
518eaab
Compare
| "enum": [ | ||
| "LLMs", | ||
| "Widgets", | ||
| "Charts", | ||
| "Authentication", | ||
| "Connections", | ||
| "Images & video", | ||
| "Audio", | ||
| "Text", | ||
| "Maps", | ||
| "Dataframes", | ||
| "Graphs", | ||
| "Molecules & genes", | ||
| "Code editors", | ||
| "Page navigation", | ||
| "Developer tools", | ||
| "Integrations" | ||
| ] |
There was a problem hiding this comment.
question: is it safe to assume this isn't difficult to adjust in the future and that this is based on the already existing categories?
There was a problem hiding this comment.
Correct, we can add or remove things as needed and are based on the existing categories right now. The full build pipeline validates all of the underlying json files against these enums, so if there any mismatches, the build will fail.
sfc-gh-nbellante
left a comment
sfc-gh-nbellante
left a comment
There was a problem hiding this comment.
Added 1 non-blocking question
sfc-gh-bnisco
force-pushed
the
01-13-_feat_add_jsonschemas
branch
from
518eaab to
0c88174
Compare
|
Closing in favor of: streamlit/gallery#3 |
2 participants
TL;DR
Added JSON schema definitions for the Component Gallery catalog system.
What changed?
compiled.schema.jsonwhich defines the structure for the compiled components catalogcomponent.schema.jsonwhich defines the structure for individual component submissionsWhy make this change?
These schema definitions provide a standardized structure for component submissions and the compiled catalog, ensuring: