inbox: add health endpoint && docs #64
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
requested changes
Oct 29, 2025
Notesnook.Inbox.API/src/index.ts
Outdated
|
|
||
| const PORT = Number(process.env.PORT || "5181"); | ||
| app.listen(PORT, () => { | ||
| isReady = true; |
Contributor
There was a problem hiding this comment.
This is pointless. The /health endpoint won't be available before the server is ready.
01zulfi
force-pushed
the
inbox/health-and-docs
branch
from
1c9d4a4 to
be375bf
Compare
01zulfi
commented
Oct 30, 2025
Comment on lines
+21
to
+24
| ## Self-hosting | ||
|
|
||
| ... | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I'm not really sure how to write this section, @thecodrr could you guide?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related streetwriters/notesnook#8526