Sourcery refactored master branch #61

sourcery-ai · 2023-11-30T08:54:37Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-11-30T08:54:39Z

python/armstrong-numbers/armstrong_numbers.py

-    total = 0
-    for char in string_num:
-        total += int(char) ** len(string_num)
+    total = sum(int(char) ** len(string_num) for char in string_num)


Function is_armstrong_number refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

sourcery-ai · 2023-11-30T08:54:39Z

python/grains/grains.py


    grains_val = 1
-    for num in range(1, number):
+    for _ in range(1, number):


Function square refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2023-11-30T08:54:39Z

python/leap/leap.py

-    if year % 4 == 0:
-        if year % 100 == 0:
-            if year % 400 == 0:
-                return True
-            return False
-        return True
-    else:
+    if year % 4 != 0:
        return False
+    return year % 400 == 0 if year % 100 == 0 else True


Function is_leap_year refactored with the following changes:

Swap if/else branches (swap-if-else-branches)

Remove unnecessary else after guard condition (remove-unnecessary-else)

Simplify boolean if expression (boolean-if-exp-identity)

Lift code into else after jump in control flow [×2] (reintroduce-else)

Replace if statement with if expression [×2] (assign-if-exp)

Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

sourcery-ai · 2023-11-30T08:54:40Z

python/pangram/pangram.py

-        return True
-    else:
-        return False
+    return len(abset) == 26


Function is_pangram refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Simplify boolean if expression (boolean-if-exp-identity)

Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

sourcery-ai · 2023-11-30T08:54:40Z

python/perfect-numbers/perfect_numbers.py

-    for val in range(1, number):
-        if number % val == 0:
-            total += val
+    total = sum(val for val in range(1, number) if number % val == 0)


Function classify refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

sourcery-ai · 2023-11-30T08:54:40Z

python/phone-number/phone_number.py

-        self.area_code = self.number[0:3]
-        if self.area_code[0] == "0" or self.area_code[0] == "1":
+        self.area_code = self.number[:3]
+        if self.area_code[0] in ["0", "1"]:


Function PhoneNumber.__init__ refactored with the following changes:

Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (remove-redundant-slice-index)

Replace multiple comparisons of same variable with in operator (merge-comparisons)

sourcery-ai · 2023-11-30T08:54:40Z

python/protein-translation/protein_translation.py

-    startidx = 0
    result = []
-    while startidx < len(strand):
+    for startidx in range(0, len(strand), 3):
        codon = strand[startidx:startidx + 3]
        if codon in STOP_CODONS:
            return result
        else:
            result.append(CODON_TO_PROTEIN[codon])
-        startidx += 3


Function proteins refactored with the following changes:

Move assignment closer to its usage within a block (move-assign-in-block)

Replace while with for (while-to-for)

sourcery-ai · 2023-11-30T08:54:40Z

python/triangle/triangle.py

-        return False
-
-    return True
+    return 0 not in sides and a + b >= c and b + c >= a and a + c >= b


Function is_triangle refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

Simplify boolean if expression (boolean-if-exp-identity)

Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

sourcery-ai · 2023-11-30T08:54:40Z

python/twelve-days/twelve_days.py

-    if start_verse == 1:
-        pieces = [start] + ["a Partridge in a Pear Tree."]
-    else:
-        pieces = [start] + LIST[-start_verse:]
-    return pieces
+    return (
+        [start] + ["a Partridge in a Pear Tree."]
+        if start_verse == 1
+        else [start] + LIST[-start_verse:]
+    )


Function recite refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai

PR Type: Refactoring

Summary of PR: This PR introduces a series of refactoring changes aimed at simplifying and optimizing the codebase. It includes the use of list comprehensions, simplification of conditional statements, and the removal of unnecessary variables and loops.

General PR suggestions

Ensure that refactored logic accurately reflects the original intent and rules, especially in cases like the leap year calculation where the logic has been significantly altered.
When simplifying expressions, particularly with mathematical operations, consider if there is a more efficient way to achieve the same result, such as using direct mathematical formulas instead of loops.
Review the changes for any potential logical errors introduced during refactoring, such as the triangle inequality condition, to maintain the correctness of the program.
While the refactoring has generally improved readability and performance, it's important to validate that the changes have not introduced any regressions or altered the behavior of the code in unintended ways.

Your trial expires on December 14, 2023. Please email tim@sourcery.ai to continue using Sourcery ✨

sourcery-ai · 2023-11-30T08:57:21Z

python/twelve-days/twelve_days.py

-    else:
-        pieces = [start] + LIST[-start_verse:]
-    return pieces
+    return (


suggestion (llm): Consider using a ternary expression directly in the return statement for improved readability.

Suggested change

return (

return [start] + (['a Partridge in a Pear Tree.'] if start_verse == 1 else LIST[-start_verse:])

sourcery-ai · 2023-11-30T08:57:21Z

python/leap/leap.py

-    else:
+    if year % 4 != 0:
        return False
+    return year % 400 == 0 if year % 100 == 0 else True


issue (llm): The refactored leap year check is incorrect. It will return True for all years not divisible by 100, which is not the correct leap year rule.

Suggested change

return year % 400 == 0 if year % 100 == 0 else True

return year % 4 == 0 and (year % 100 != 0 or year % 400 == 0)

sourcery-ai · 2023-11-30T08:57:22Z

python/triangle/triangle.py

-        return False
-
-    return True
+    return 0 not in sides and a + b >= c and b + c >= a and a + c >= b


issue (llm): The triangle inequality check should use strict inequality '>' rather than '>=' to ensure that the sum of the lengths of any two sides must be greater than the length of the remaining side.

Suggested change

return 0 not in sides and a + b >= c and b + c >= a and a + c >= b

return 0 not in sides and a + b > c and b + c > a and a + c > b

sourcery-ai · 2023-11-30T08:57:22Z

python/protein-translation/protein_translation.py

-    startidx = 0
    result = []
-    while startidx < len(strand):
+    for startidx in range(0, len(strand), 3):


praise (llm): Good job on simplifying the loop for iterating over the codons using a range with a step of 3.

sourcery-ai · 2023-11-30T08:57:22Z

python/grains/grains.py


    grains_val = 1
-    for num in range(1, number):
+    for _ in range(1, number):


suggestion (llm): Instead of using a loop to calculate the number of grains, consider using a direct mathematical expression for better performance.

Suggested change

for _ in range(1, number):

return 2 ** (number - 1)

'Refactored by Sourcery'

3670801

sourcery-ai bot requested a review from strickvl November 30, 2023 08:54

sourcery-ai bot commented Nov 30, 2023

View reviewed changes

	return (
	return [start] + (['a Partridge in a Pear Tree.'] if start_verse == 1 else LIST[-start_verse:])

	return year % 400 == 0 if year % 100 == 0 else True
	return year % 4 == 0 and (year % 100 != 0 or year % 400 == 0)

	return 0 not in sides and a + b >= c and b + c >= a and a + c >= b
	return 0 not in sides and a + b > c and b + c > a and a + c > b

Sourcery refactored master branch #61

Are you sure you want to change the base?

Sourcery refactored master branch #61

Uh oh!

Conversation

sourcery-ai bot commented Nov 30, 2023

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant