First-pass charmap generator script #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @GCC-Cardoso! Thanks for the contribution, and sorry for the delay... |
lucasgpulcinelli
requested changes
Oct 9, 2022
Collaborator
lucasgpulcinelli
left a comment
lucasgpulcinelli
left a comment
There was a problem hiding this comment.
I have a general request too, the charmap in the example contains only numbers, could you also add one that has the normal ascii table (as most games tend to use it, and as we talked personally)?
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| f_name = input("File name for the image to use for charmap generation: ") |
Collaborator
There was a problem hiding this comment.
Could you use sys.argv to get the file name for inputs and outputs and link them in the Makefile? That is the standart way we are developing the tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.