fix: javadoc for isthmus-cli and examples #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
nielspardon
reviewed
Jan 8, 2026
examples/isthmus-api/src/main/java/io/substrait/examples/SchemaHelper.java
Outdated
Show resolved
Hide resolved
nielspardon
reviewed
Jan 8, 2026
examples/isthmus-api/src/main/java/io/substrait/examples/SchemaHelper.java
Outdated
Show resolved
Hide resolved
nielspardon
reviewed
Jan 8, 2026
examples/substrait-spark/src/main/java/io/substrait/examples/util/ParentStringify.java
Outdated
Show resolved
Hide resolved
nielspardon
reviewed
Jan 8, 2026
examples/substrait-spark/src/main/java/io/substrait/examples/util/ParentStringify.java
Outdated
Show resolved
Hide resolved
nielspardon
reviewed
Jan 8, 2026
examples/substrait-spark/src/main/java/io/substrait/examples/util/TypeStringify.java
Outdated
Show resolved
Hide resolved
nielspardon
reviewed
Jan 8, 2026
isthmus-cli/src/main/java/io/substrait/isthmus/cli/RegisterAtRuntime.java
Outdated
Show resolved
Hide resolved
nielspardon
reviewed
Jan 8, 2026
isthmus-cli/src/main/java/io/substrait/isthmus/cli/InitializeAtBuildTime.java
Show resolved
Hide resolved
|
|
mbwhite
force-pushed
the
fix-javadoc-b
branch
3 times, most recently
from
489aa3f to
90cbed3
Compare
Contributor
Author
|
@nielspardon @bestbeforetoday @benbellick @vbarua @andrew-coleman |
Member
|
There seems to be a merge conflict so you will need to rebase. That might explain why this PR is currently modifying the substrait submodule. |
JavaDoc fixes to ensure the examples and isthmus-cli are clean. Not expecting these to be published, as not APIs to use directly. Signed-off-by: MBWhite <whitemat@uk.ibm.com>
…SchemaHelper.java Co-authored-by: Niels Pardon <mail@niels-pardon.de>
…SchemaHelper.java Co-authored-by: Niels Pardon <mail@niels-pardon.de>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
fix-javadoc-b
branch
from
90cbed3 to
e274a2a
Compare
Contributor
Author
|
@bestbeforetoday I've rebased this off main update - tried to update the submodule |
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
bestbeforetoday
requested changes
Jan 16, 2026
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
This change is currently adding back in the previously deleted isthmus-cli/src/main/java/io/substrait/isthmus/cli/InitializeAtBuildTime.java file.
Otherwise looks good to me. Certainly an improvement on what was (or wasn't) there before. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaDoc fixes to ensure the examples and isthmus-cli are clean. Not expecting these to be published, as not APIs to use directly.