Merged
Conversation
When a pydantic_action function has a 'state' parameter without type annotation, raise a clear ValueError explaining that the parameter must be annotated with a pydantic.BaseModel subclass, instead of a cryptic KeyError. Closes #385 Signed-off-by: majiayu000 <1835304752@qq.com>
…ster (#613) * fix(persistence): improve error message for uninitialized SQLitePersister When load(), save(), or list_app_ids() are called before initialize(), raise a clear RuntimeError with actionable guidance instead of cryptic sqlite3.OperationalError about missing table. Closes #417 Signed-off-by: majiayu000 <1835304752@qq.com> * refactor: extract error message to constant Address review feedback: extract the uninitialized persister error message to a module-level constant _UNINITIALIZED_PERSISTER_ERROR and use it in all three places (list_app_ids, load, save). --------- Signed-off-by: majiayu000 <1835304752@qq.com>
* Update serde.rst As agreed here #554 it would be helpful to mention some limitations/caveats. * Update serde.rst adds limitation note --------- Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )