Open
Conversation
In the for-loop which creates the empty dirs in ARC_DIR, an entry for "labels" was missing.
bugfix: error if labels are present
sue445
reviewed
Jan 11, 2021
| fi | ||
|
|
||
| if [ "$(ls -A ${JENKINS_HOME}/labels/)" ] ; then | ||
| cp -R "${JENKINS_HOME}/labels/"* "${ARC_DIR}/labels" |
Owner
There was a problem hiding this comment.
@cafhach [MUST] Add a test case below to see if the labels directory is really archived
jenkins-backup-script/spec/jenkins-backup_spec.rb
Lines 1 to 27 in 85e4519
sue445
requested changes
Jan 11, 2021
| cp "${JENKINS_HOME}/"*.xml "${ARC_DIR}" | ||
|
|
||
| cp "${JENKINS_HOME}/.owner" "${ARC_DIR}" | ||
| ls "${JENKINS_HOME}/plugins" > ${ARC_DIR}/content_of_plugins_folder.txt |
Owner
There was a problem hiding this comment.
@cafhach [QUESTION] Is this really necessary?
The subject of this PR is the addition of the labels directory, But I don't think this is relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"labels" directory is now backuped as well