Open
Conversation
karthik-tarento
changed the base branch from
release-4.8.0
to
release-4.8.0_cb
karthik-tarento
changed the base branch from
release-4.8.0_cb
to
release-4.8.0
karthik-tarento
suggested changes
Nov 9, 2022
|
|
||
| search.es_conn_info="localhost:9200" | ||
| search.fields.query=["name^100","title^100","lemma^100","code^100","domain","subject","description^10","keywords^100","ageGroup^10","filter^10","theme^10","genre^10","objects^25","contentType^100","language^200","teachingMode^25","skills^10","learningObjective^10","curriculum^100","gradeLevel^100","developer^100","attributions^10","identifier^100","IL_UNIQUE_ID^100","owner^50","board^100","relatedBoards^100","creator^100", "dialcodes^100","text","words","releaseNotes"] | ||
| search.fields.query=["name^100.0","keywords^60.0","competencies_v3.name^60.0","systemTopics^60","purpose^60","source^50.0","description^5.0","language^5.0"] |
There was a problem hiding this comment.
Check this can be over ridden via deployment script -- so that no code change is required.
| return searchDTO.isFuzzySearch() ? prepareFilteredSearchQuery(searchDTO) : prepareSearchQuery(searchDTO); | ||
| } | ||
|
|
||
| return searchDTO.isFuzzySearch() ? (prepareSearchQuery(searchDTO) == null ? prepareFilteredSearchQuery(searchDTO) : prepareSearchQuery(searchDTO)) : prepareSearchQuery(searchDTO); |
There was a problem hiding this comment.
What are the chances of prepareSearchQuery becomes null ?
If prepareSearchQuery is not null - then the default SB behaviour of calling prepareFilteredSearchQuery won't be used in Sunbird environment. So this solution can not be proposed to Sunbird - we need better way of coding which is not causing any issues in Sunbird environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for Course search API