Skip to content

🐛 Allow loosely false values to not violate unique constraints not jus… #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardfwashington wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Allow loosely false values to not violate unique constraints not jus… #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/seed/src/core/plan/constraints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@ export async function checkConstraints(
const sortedConstraints = sortBy(filteredConstraints, (c) => c.fields.length);

for (const constraint of sortedConstraints) {
// We skip the constraint if it contains null values
if (
constraint.fields.some((c) => props.modelData[c] === null) &&
// We skip the constraint if it contains nullish values
if (!constraint.fields.some((c) => props.modelData[c]) &&
// Execpt if the constraint is nullNotDistinct so each null values isn't considered distinct
// from the other null values anymore (maximum one null value is allowed)
!constraint.nullNotDistinct
Expand Down