Merged
Conversation
avallete
commented
Mar 19, 2024
| await seed.orders([{ | ||
| quantity: 10, | ||
| productsByFirstOrderId: { | ||
| firstOrderId: (ctx) => ctx.$store.orders[0].id!, |
Contributor
Author
There was a problem hiding this comment.
remark
I left this one in a .todo test, weirdly enough I would expect this to work as it passes the type check. But this fail because in firstOrderId we don't have a literal.
So either we need to change the types, or we need to fix this bug.
justinvdm
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before working more on #21 I've migrated the
store.tests.tsthere into e2e testings.I think it's a better option to ensure we won't tests "impossibles" states in our store.